JSON for Hash now has to be Base16
#14536
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
with-tests
Fix #14532. As discussed on the call today: 1. We'll stick with `format = "base16"` and `hash = "<hash>"`, not do `base16 = "<hash>"`, in order to be forward compatible with supporting more versioning formats. The motivation we discussed for someday *possibly* doing this is making it easier to write very slap-dash lang2nix tools that create (not consume) derivations with dynamic derivations. 2. We will remove support for non-base16 (and make that the default, not base64) in `Hash`, so this is strictly forward contingency, *not* yet something we support. (And also not something we have concrete plans to start supporting.)
Ericson2314
force-pushed
the
clamp-down-hash
branch
from
949a9fa to
13b4474
Compare
Member
|
Did we accidentally duplicate the derivation outputs fixed output output format earlier? ...
"name": "bash-5.3.tar.gz",
"outputs": {
"out": {
"hash": {
// howdy
"algorithm": "sha256",
"format": "base64",
"hash": "DVzYaWX4aaJs9k9Lcb57lvkKO6iz104n6OnZ1VUPMbo="
},
"method": "flat"
}
}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #14532.
Context
As discussed on the call today:
We'll stick with
format = "base16"andhash = "<hash>", not dobase16 = "<hash>", in order to be forward compatible with supporting more versioning formats.The motivation we discussed for someday possibly doing this is making it easier to write very slap-dash lang2nix tools that create (not consume) derivations with dynamic derivations.
We will remove support for non-base16 (and make that the default, not base64) in
Hash, so this is strictly forward contingency, not yet something we support. (And also not something we have concrete plans to start supporting.)Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.